compiletest: Add LineNumber newtype to avoid +1 magic here and there#150205
Merged
bors merged 1 commit intorust-lang:mainfrom Dec 23, 2025
Merged
compiletest: Add LineNumber newtype to avoid +1 magic here and there#150205bors merged 1 commit intorust-lang:mainfrom
LineNumber newtype to avoid +1 magic here and there#150205bors merged 1 commit intorust-lang:mainfrom
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Start small. If it works well we can increase usage bit by bit as time passes.
My main motivation for doing this is to get rid of the
+ 1I otherwise have to add in #150201 on this line:But I think this is a nice general improvement by itself.
Note that we keep using "0" to represent "no specific line" because changing to
Option<LineNumber>everywhere is a very noisy and significant change. That can be changed later if wanted, but let's not do it now.